Re: [PATCH] push: change submodule default to check

On Thu, Aug 18, 2016 at 7:09 AM, Heiko Voigt [off-list ref] wrote:

On Wed, Aug 17, 2016 at 02:14:11PM -0700, Stefan Beller wrote:

quoted

On Wed, Aug 17, 2016 at 2:05 PM, Junio C Hamano [off-list ref] wrote:

quoted

Stefan Beller [off-list ref] writes:

[...]

quoted

quoted

quoted

Flipping the default to check for submodules is safer
than the current default of ignoring submodules while pushing.

That part of the assertion, on the other hand, is justifiable.

ok.

I also think that this is a good reason to flip the default. IMO more
people will be annoyed by not being able to checkout a certain version
if someone forgets to push a submodule then people deliberately pushing
something with a submodule hash that is not on any remote.

At the same time I am wondering whether it makes sense to keep this for
a bigger version change (like 3.0) or so? Since that is were people will
expect such changes. Not sure when 3.0 is planned though.

Cheers Heiko

I guess we can postpone it until 3.0, though I currently think it is not a big
issue as it helps avoiding "bugs in your workflow".

On the other hand if you really want to push out the superproject without
the submodules, you need to adapt your behavior (i.e. set an option or
give a command line flag), and such breaking things we should delay
until 3.0.

I think I'll resend it with a proper commit message, such that we can just pick
it up when 3.0 comes around.

Thanks,
Stefan