[PATCH v10 0/9] submodule inline diff format · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 1/9] Git 2.10-rc1 · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
Re: [PATCH v10 1/9] Git 2.10-rc1 · Stefan Beller <hidden> · 2016-08-23
Re: [PATCH v10 1/9] Git 2.10-rc1 · Jacob Keller <hidden> · 2016-08-23
[PATCH v10 7/9] submodule: convert show_submodule_summary to use struct object_id * · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 3/9] diff.c: remove output_prefix_length field · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 6/9] allow do_submodule_path to work even if submodule isn't checked out · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 4/9] graph: add support for --line-prefix on all graph-aware output · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 5/9] diff: prepare for additional submodule formats · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 2/9] cache: add empty_tree_oid object and helper function · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 9/9] diff: teach diff to display submodule difference with an inline diff · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
[PATCH v10 8/9] submodule: refactor show_submodule_summary with helper function · Jacob Keller <jacob.e.keller@intel.com> · 2016-08-22
Re: [PATCH v10 0/9] submodule inline diff format · Stefan Beller <hidden> · 2016-08-23
Re: [PATCH v10 0/9] submodule inline diff format · Jacob Keller <hidden> · 2016-08-23

Re: [PATCH v10 0/9] submodule inline diff format

From: Stefan Beller <hidden>
Date: 2016-08-23 01:08:10

On Mon, Aug 22, 2016 at 4:43 PM, Jacob Keller [off-list ref] wrote:

From: Jacob Keller <redacted>

A few suggestions from Stefan in regards to falling back to
.git/modules/<path> being a bad idea. I've chosen I think to avoid using
die() as we just stick with the current path if we can't find its name.

Which makes the existing bug more subtle :(

I think this should be safe since we already do this today.

It's a bug today already. Thanks for spotting!

The new flow
only changes if we are able to lookup the submodule, so I don't think
it's worth adding a die() call.

Well this series improves the buggy-ness as it is only buggy when the name
is not found, and we fall back on the path.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help