On Mon, Aug 22, 2016 at 4:43 PM, Jacob Keller [off-list ref] wrote:
From: Jacob Keller <redacted>
A few suggestions from Stefan in regards to falling back to
.git/modules/<path> being a bad idea. I've chosen I think to avoid using
die() as we just stick with the current path if we can't find its name.
Which makes the existing bug more subtle :(
I think this should be safe since we already do this today.
It's a bug today already. Thanks for spotting!
The new flow
only changes if we are able to lookup the submodule, so I don't think
it's worth adding a die() call.
Well this series improves the buggy-ness as it is only buggy when the name
is not found, and we fall back on the path.