Re: [PATCH v8 6/8] submodule: refactor show_submodule_summary with helper function

On Fri, Aug 19, 2016 at 1:24 PM, Junio C Hamano [off-list ref] wrote:

And probably merge_bases also leaks here.

It is not cheap to compute merge bases, but show_submodule_summary()
makes two calls to get_merge_bases(), one in show_submodule_header()
and then another inside prepare_submodule_summary() to compute
exactly the same set of merge bases.  We somehow need to reduce it
to just one.

I can make show_submodule_headers take another parameter which we
pass, and then pass that into prepare_submodule_summary...?

Thanks,
Jake