Thread (27 messages) 27 messages, 3 authors, 2016-09-09

Re: [PATCH 4/4] cat-file: support --textconv/--filters in batch mode

From: Johannes Schindelin <hidden>
Date: 2016-08-19 12:26:22

Hi Torsten,

On Thu, 18 Aug 2016, Torsten Bögershausen wrote:
On Thu, Aug 18, 2016 at 02:46:28PM +0200, Johannes Schindelin wrote:
quoted
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index 5ff58b3..5f91cf4 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -17,6 +17,7 @@ struct batch_options {
 	int print_contents;
 	int buffer_output;
 	int all_objects;
+	int cmdmode; /* may be 'w' or 'c' for --filters or --textconv */
How do I read 'w' and 'c' ?
wilter and cextconv ? Does it make sense to use an enum here ?
Or a #define ?
Sorry, Torsten, this is not my doing. So I cannot explain why it is not an
enum.

I *guess* the rationale for 'c' being the cmdmode of --textconv is "c for
convert". That is why I chose "w as in worktree" as new cmdmode.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help