Re: [PATCH 2/2] checkout: do not mention detach advice for explicit --detach option

Jeff King [off-list ref] writes:

I don't think doing it this way is _wrong_. It just feels sort of
pointlessly over-engineered. It's also a little weird that all of the:

  if (advice_foo)

will trigger because "advice_foo" is set to -1. I think it does the
right thing, but it feels like a bug (the value is now a tri-state, and
we silently collapse two states into one).

Guilty as charged.  I do agree that this is over-engineered.