Re: [PATCH] sha1_file: don't malloc the whole compressed result when writing out objects

From
Junio C Hamano <hidden>
Date
2016-08-13 23:25:33
Nicolas Pitre [off-list ref] writes:
quoted
Having said all that, I like your approach better.  It is not worth paying
the price of unnecessary memcpy(3) that would _only_ help catching the
insanely artificial test case, but your patch strikes a good balance of
small overhead to catch the easier-to-trigger (either by stupidity, malice
or mistake) cases.
I think it also catches the bad RAM case which is probably more common 
too.
That is true; a broken RAM that returns unstable values will yield
different values between the time the first hash runs and the time the
deflate loop runs will trigger the safety.
Thread (1 message) 1 message, 1 author, last reply 2016-08-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help