Thread (13 messages) flat view 13 messages, 2 authors, 2016-08-13

Re: [PATCH 3/7] http-push: remove useless condition

From: Tay Ray Chuan <hidden>
Date: 2016-08-13 23:25:23

Hi,

On Sun, Feb 21, 2010 at 6:40 PM, Clemens Buchacher [off-list ref] wrote:
On Sun, Feb 21, 2010 at 11:08:24AM +0800, Tay Ray Chuan wrote:
quoted
-                     if (push_verbosely || 1)
+                     if (push_verbosely)
                              fprintf(stderr, "'%s': up-to-date\n", ref->name);
Just a minor nit-pick. If you end up doing a resend, maybe you could change
the commit message to this one, since you're actually adding a condition
that was previously disabled, not removing it.
yes, that makes sense..

-- 
Cheers,
Ray Chuan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help