Thread (3 messages) flat view 3 messages, 3 authors, 2016-08-11

Re: [PATCH 3/5] get_shallow_commits: Avoid memory leak if a commit has been reached already.

From: Anand Kumria <hidden>
Date: 2016-08-11 20:42:25

On Fri, 24 Nov 2006 15:58:50 +0100, Alexandre Julliard wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Alexandre Julliard <redacted>
---
 shallow.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/shallow.c b/shallow.c
index 2db1dc4..3d53d17 100644
--- a/shallow.c
+++ b/shallow.c
@@ -60,7 +60,9 @@ struct commit_list *get_shallow_commits(
 					commit = NULL;
 					continue;
 				}
-				commit->util = xcalloc(1, sizeof(int));
+				if (!commit->util)
+					commit->util = xmalloc(sizeof(int));
+				*(int *)commit->util = 0;
 				cur_depth = 0;
Hi,

Any reason you didn't do:

if (!commit->util)
	commit->util = xcalloc(1, sizeof(int));

That would seem to be the same.

Regards,
Anand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help