Thread (1 message) 1 message, 1 author, 2016-08-11
  • (off-list ancestor, not in this archive)
  • Re: t0027 racy? · Junio C Hamano <hidden> · 2016-08-11

Re: t0027 racy?

From: Junio C Hamano <hidden>
Date: 2016-08-11 20:42:20

Torsten Bögershausen [off-list ref] writes:
Good ideas, I will work on a series that fixes bugs first, and then we
can see if there is room for optimization.

What do you think about this as a starting point, more things will
follow.
I like to here comments about the commit msg first ;-)
Throughout t0027 there is no mention on what NNO stands for.  Are
they about operations that result in un-normalized index entries?
commit 3754404d3d1ea4a0cbbed4986cc4ac1b5fe6b66e
Author: Torsten Bögershausen [off-list ref]
Date:   Thu Aug 11 18:47:29 2016 +0200

    t0027: Correct raciness in NNO test
    
    When a non-reversible CRLF conversion is done in "git add",
    a warning is printed on stderr.
    
    The commit_chk_wrnNNO() function  in t0027 was written to test this,
    but did the wrong thing: Instead of looking at the warning
    from "git add", it looked at the warning from "git commit".
    
    Correct this and replace the commit for each and every file with a commit
    of all files in one go.
    
    The function commit_chk_wrnNNO() will to be renamed in a separate commit.
    Thanks to Jeff King [off-list ref] for analizing t0027.
    Reporyed-By: Johannes Schindelin [off-list ref]
Reporyed?  

An obligatory "comments-about-the-commit-msg";-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help