Thread (17 messages) flat view 17 messages, 4 authors, 2016-08-11

Re: bug: git-sh-setup should not be in $PATH

From: Han-Wen Nienhuys <hidden>
Date: 2016-08-11 20:38:58

Jakub Narebski escreveu:
Still I think that at least

  datarootdir = @datarootdir@

should be not removed.
yes, agreed.
quoted
quoted
quoted
+  if test -f $srcdir/$d/Makefile ; then
  [..]
quoted
quoted
quoted
+    echo creating $d/Makefile
+    cat << EOF> $d/Makefile
quoted
quoted
This part IMHO has no sense, and has no place here.
If you want to create or modify Makefiles, do that. Not generate
"minimal" Makefiles in every and each subdirectory.
Look more closely at the patch. It only generates Makefiles in 
directories that have makefiles in the source dir. The makefiles are
short because that is the easiest to do.

I'm happy to amend the patch, bUt I can't properly test
it until the perl problem gets sorted out. 

-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help