Thread (1 message) 1 message, 1 author, 2016-08-11

Re: [PATCH] Avoid accessing a slow working copy during diffcore operations.

From: Junio C Hamano <hidden>
Date: 2016-08-11 20:30:57

Johannes Schindelin [off-list ref] writes:
On Fri, 15 Dec 2006, Junio C Hamano wrote:
quoted
Also I'd prefer doing this without #ifdef;

        if (defined(NO_FAST_WORKING_DIRECTORY) &&
        	!want_file && has_sha1_pack(sha1, NULL))
		return 0;
Are you sure? AFAIU it is an OS dependent problem, so it should not be 
configurable at runtime anyway.
Well, defined(SYMBOL) does not seem to be a valid C X-<, and I
rewrote it in what I committed.  But the point was that the
whole thing:

	if (!FAST_WORKING_DIRECTORY && whatever)
		statement;

when FAST_WORKING_DIRECTORY is a compilation time constant,
would be optimized out for sane platforms with a reasonable
compiler.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help