Re: [PATCH/RFC (take 2)] gitweb: New improved patchset view

Junio C Hamano wrote:

Jakub Narebski [off-list ref] writes:

quoted

3. Should we make from-range/to-range in chunk header hyperlink to the 
start of given bunch of lines in appropriate file? Or perhaps to the 
middle of the bunch of lines? Or to first changed line (omitting 
context)?

I do not see what usage pattern this link would help.  Care to
explain a bit better?

For example for the following header

diff --git _a/gitweb/gitweb.perl_ _b/gitweb/gitweb.perl_

index _cbab3c9_.._a5a140c_ 100755

--- a/_gitweb/gitweb.perl_
+++ b/_gitweb/gitweb.perl_

@@ _-1255,9_ _+1255,12_ @@ sub parse_difftree_raw_line {

The '-1255,9' would be link to older version of gitweb/gitweb.perl file,
directly to the line #1255 (or to first changed line, or to the middle
of the chunk i.e. 1255+9/2 line).

The '+1255,12' would be link to newer version of file, to line 1255.
-- 
Jakub Narebski