Re: gitk broken or user error?

Seth Falcon writes:

I tried a certainly incorrect thing; just commenting out the offending
lines:

[snip]

-    .bar.view entryconf 2 -state normal
-    .bar.view entryconf 3 -state normal
+#    .bar.view entryconf 2 -state normal
+#    .bar.view entryconf 3 -state normal
 }
 
 if {[info exists permviews]} {

And now gitk _seems_ to work.  No error message, and I can pass
argument to gitk like --all (wow, very useful).

Those lines are intended to enable the "Edit view" and "Delete view"
entries in the View menu.  Those entries start out disabled and are
supposed to be disabled when the "All files" view is displayed, and
enabled when any other view is displayed.

I suspect that under OSX, the menu gets an extra entry, or something,
that throws off the numbering.  Instead of commenting out those lines,
could you instead try changing the 2 and 3 to "Edit*" and "Delete*"
instead?  If that works I'll do a patch to fix the problem properly.

I posted about this in October [*1*], but didn't get any response.

I tend to read the git list intermittently (lkml and linuxppc-dev keep
me pretty much occupied :).  Please cc me on any gitk bug reports.