Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying
From: Jeff King <hidden>
Date: 2016-08-11 20:21:28
Possibly related (same subject, not in this thread)
- 2016-08-11 · Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying · Martin Langhoff (CatalystIT) <hidden>
- 2016-08-11 · Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying · Junio C Hamano <hidden>
- 2016-08-11 · Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying · Ignacio Arenaza <hidden>
- 2016-08-11 · Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying · Ignacio Arenaza <hidden>
- 2016-08-11 · Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying · Ignacio Arenaza <hidden>
On Fri, Nov 24, 2006 at 12:57:49AM -0800, Junio C Hamano wrote:
+ # Skip up to the empty line of the proxy server output
+ # including the response headers.
+ while ($rep = <$s>) {
+ last if (!defined $rep ||
+ $rep eq "\n" ||
+ $rep eq "\r\n");
+ }Nit: checking defined($rep) inside the loop is redundant.