Thread (1 message) 1 message, 1 author, 2016-08-11

Re: [PATCH] Adjust t5510 to put remotes in config

From: Johannes Schindelin <hidden>
Date: 2016-08-11 20:20:13

Hi,

On Mon, 18 Dec 2006, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
Since .git/remotes/ is no longer created by default, t5510 failed.
Does not reproduce for me.
I just checked out a fresh copy of 'next'. It still fails. The culprit is 
61dde8f91672ab362f3cfd3af8d6d09d448d4ffe, which removes the line

		mkdir -p "$GIT_DIR/remotes" &&

which is line 372 in the parent of that commit.
quoted
While at it, convert the tests to use the config way of specifying
remotes instead of creating a file in .git/remotes/.
I think adding tests to use config is good, but I'd rather see
the test scripts to test not _only_ config but both.
Okay. How about fixing the first hunk as proposed, and the second by 
'mkdir .git/remotes'?

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help