Re: Avoiding uninteresting merges in Cairo
From: Shawn Pearce <hidden>
Date: 2016-08-11 20:19:55
Jakub Narebski [off-list ref] wrote:
Do you mean "commit" view or "commitdiff" view in gitweb for merges is confusing?
The commit view was what was confusing me.
If it is "commit" view, it is fairly easy to remove difftree/whatchanged output below commit message for merges. However while git-show nor git-diff-tree doesn't show diff for merge messages, the diftree output in "commit" view might be taken as 'damages'; git diff --summary always takes summary of diff against first parent.
I can see that, but it depends on what the current branch was when you do the merge. In the cairo case I was looking at yesterday the "damages" from the merge were actually what was already considered to be in the mainline as part of the project due to committer pulling the remote master into his own master before pushing. Given that the "push; whoops; pull; push" pattern is so common to Git I think it is sort of misleading to show a merge like this; lots of activity may have been pulled in from the central branch during that pull. iirc git whatchanged for a merge shows only files which cannot be found in any of the parents; these the files which the merge commit itself contributed directly. If that set is empty then the commit just isn't shown by git whatchanged. --