Thread (1 message) 1 message, 1 author, 2016-08-11

Re: [PATCH 2/5] support fetching into a shallow repository

From: Junio C Hamano <hidden>
Date: 2016-08-11 20:12:03

Johannes Schindelin [off-list ref] writes:
quoted
I think the "commit = p->item" part is trying to do a tail
recursion optimization, but this is a bit too clever to my
liking (at first I mistook that the code forgot to re-point p at
its parents list and incrementing cur_depth).
I take it as a compliment ;-)

Seriously again, would you like me to add a comment, or rather do away 
with the tail recursion optimization? It is not a huge optimization 
anyway. Maybe a cleverer way would be to use an object_array instead of a 
commit_list?
Leaving it as a compliment is just fine.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help