Thread (8 messages) flat view 8 messages, 4 authors, 2016-08-11

Re: [WISH] Store also tag dereferences in packed-refs

From: Jakub Narebski <hidden>
Date: 2016-08-11 20:02:08

Linus Torvalds wrote:
On Sun, 19 Nov 2006, Junio C Hamano wrote:
quoted
Did you do this "if (isspace(*line)) return NULL" to have
extensibility later, I wonder...
No, but I try to have a policy of not accepting anything that is even 
slightly questionable, so it was unintentional in the details but a result 
of a higher-level principle..

Of course, even when I wrote it I _also_ knew that I should check 
everything else too (not just the first character), but I was lazy. That 
would have been even better - then we could have made the thing be 
something like

      <sha1><space><name>[<space><sha1-of-deref>]*

instead.
So the only reason against this format (IMHO more reasonable, more readable
and more readable, and even easy extendable to the whole chain of derefs)
is code in the wild? 

By the way, do we copy packed refs literaly when fetching or cloning?
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help