Thread (8 messages) flat view 8 messages, 6 authors, 2016-08-11

Re: On removing files and "git-rm is pointless"

From: Jakub Narebski <hidden>
Date: 2016-08-11 19:56:35

Junio C Hamano wrote:
Nicolas Pitre [off-list ref] writes:
quoted
I think what Linus is proposing makes tons of sense.

If you do git rm by mistake then you can always do git checkout on that
file to get it back.

If you modified it so it doesn't match the index then git rm won't do
anything by default so you have a chance to think a bit more.

If you updated the index, didn't commit anything but then do git rm then
you certainly wanted to really rm the file.
FWIW, I too am in favor of the proposed fix to "git rm" as Linus
outlined.
+1. I'm also for this change. Of course if the working area version doesn't
match HEAD version git-rm should remove only index entry, and print warning
message, for example what it does now, i.e.
  rm '<filename>'
or if we want more chatty version (core.gitgor = true) it would print:
  File '<filename>' changed. Use "rm '<filename>'" to remove.
(or something like that).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help