Thread (1 message) 1 message, 1 author, 2016-08-11

Re: [PATCH] Small optimizations to gitweb

From: Junio C Hamano <hidden>
Date: 2016-08-11 19:44:37

Jakub Narebski [off-list ref] writes:
Junio C Hamano wrote:
quoted
...
The counting code in git_*_body is seriously unusual to tempt
anybody who reviews the code to reduce that 17 to 16.
Well, this should be then corrected perhaps to
Well, I did not say it was _wrong_, just unusual, so there is
nothing to fix.
quoted
By the way, I wonder how that $extra is omitted when $revlist is
longer than $to; it should be a trivial fix but it seems to me
that it is always spitted out with the current code.
We should check if we want to omit $extra, either in caller or
in callee, the *_body subroutine itself.
Check?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help