Thread (1 message) 1 message, 1 author, 2016-08-11

Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

From: Junio C Hamano <hidden>
Date: 2016-08-11 19:31:13

Eric Wong [off-list ref] writes:
Junio C Hamano [off-list ref] wrote:
quoted
Please CC people who are primarily working on the part of the
system you are improving.  In the case of git-svn that would be
Eric Wong.
Yes, CCs regarding git-svn would be much appreciated, thanks.
...
Please fix the coding style so that it's consistent with the rest of
git-svn:
Thanks Eric for your quick response.
a) indentation is done with hard tabs
b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"

Also, adding tests would be helpful in helping me maintain it (I'm not
a regular svk user, so I don't want to break anything you've done down
the line).
Another request from the maintainer is to Sign-off the patches.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help