Re: [PATCH 3/3] git-fetch: allow glob pattern in refspec

On Thursday 2006 November 23 07:24, Junio C Hamano wrote:

 * Andy, I think this does the same thing as you wanted to do,
   but is cleaner implementation-wise and also at the concept

It certainly is.  Looking at your implementation I see that I was worrying 
unnecessarily about passing extra globals/parameters to git-parse-remote.  
Your version is much better than mine; and I see that noone else calls 
get_remote_refs_for_fetch anyway.

   level, to pretend as if the user listed the expanded form in
   the configuration.  I deliberately decided not to apply the
   wildcard expansion on refspecs that came from command line,
   but if we wanted to we can move the expand_refs_wildcard call
   a few lines down to make it also apply to them.

That's probably the most sensible method.  Using globs on the command line 
could get people into trouble if they accidentally hit a shell expansion.


Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE