Re: filemode=false somewhat broken

Junio C Hamano [off-list ref] wrote:

Juergen Ruehle [off-list ref] writes:

quoted

Commit fd28b34afd9bbd58297a25edced3f504c9a5487a tried to ignore the
executable bit if filemode=false, but instead forced all files to be
regular with 644 permission bits nuking symlink support.

Thanks for noticing.  Yes, that change is _seriously_ broken.  I
should really raise the bar for patch acceptance.

Whoops.

I don't work with symlinks so I never noticed the breakage myself.
Clearly the test cases that I created in fd28b3 should also have
included symlinks, but they did not...  and we see this breakage
occur.

--