Re: [PATCH 4/6] introduce a commit metapack

On Wed, Jan 30, 2013 at 10:36:10AM +0700, Nguyen Thai Ngoc Duy wrote:

On Tue, Jan 29, 2013 at 4:16 PM, Jeff King [off-list ref] wrote:

quoted

+int commit_metapack(unsigned char *sha1,
+                   uint32_t *timestamp,
+                   unsigned char **tree,
+                   unsigned char **parent1,
+                   unsigned char **parent2)
+{

Nit picking. tree, parent1 and parent2 can/should be "const unsigned char **".

Thanks, I'll fix it in the next version.