Re: [PATCH 015/144] t0204-gettext-reencode-sanity.sh: use the $( ... ) construct for command substitution

2 messages, 2 authors, 2016-08-11 · open the first message on its own page

Re: [PATCH 015/144] t0204-gettext-reencode-sanity.sh: use the $( ... ) construct for command substitution

From: Matthieu Moy <hidden>
Date: 2016-08-11 17:45:59

Elia Pinto [off-list ref] writes:
quoted hunk
--- a/t/t0204-gettext-reencode-sanity.sh
+++ b/t/t0204-gettext-reencode-sanity.sh
@@ -58,7 +58,7 @@ test_expect_success GETTEXT_LOCALE 'gettext: Fetching a UTF-8 msgid -> UTF-8' '
 # How these quotes get transliterated depends on the gettext implementation:
 #
 #   Debian:  ,einfaldar' og ,,tvöfaldar" [GNU libintl]
-#   FreeBSD: `einfaldar` og "tvöfaldar"  [GNU libintl]
+#   FreeBSD: $(einfaldar) og "tvöfaldar"  [GNU libintl]
 #   Solaris: ?einfaldar? og ?tvöfaldar?  [Solaris libintl]
I don't think you wanted this to be changed.

-- 
Matthieu Moy

Re: [PATCH 015/144] t0204-gettext-reencode-sanity.sh: use the $( ... ) construct for command substitution

From: Elia Pinto <hidden>
Date: 2016-06-15 23:00:31

2014-03-25 9:36 GMT+01:00 Matthieu Moy [off-list ref]:
Elia Pinto [off-list ref] writes:
quoted
--- a/t/t0204-gettext-reencode-sanity.sh
+++ b/t/t0204-gettext-reencode-sanity.sh
@@ -58,7 +58,7 @@ test_expect_success GETTEXT_LOCALE 'gettext: Fetching a UTF-8 msgid -> UTF-8' '
 # How these quotes get transliterated depends on the gettext implementation:
 #
 #   Debian:  ,einfaldar' og ,,tvöfaldar" [GNU libintl]
-#   FreeBSD: `einfaldar` og "tvöfaldar"  [GNU libintl]
+#   FreeBSD: $(einfaldar) og "tvöfaldar"  [GNU libintl]
 #   Solaris: ?einfaldar? og ?tvöfaldar?  [Solaris libintl]
I don't think you wanted this to be changed.
Certainly not. The change was made by an automated script, can happen
that i missed something.

Please skip this patch.

Thank you very much for the review.


Elia
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help