Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

On Wed, Aug 10, 2016 at 03:59:19PM +0200, Lars Schneider wrote:

quoted

It does still feel a little weird that you cannot tell the difference
between a write() error and bad input. Because you really might want to
do something different between the two. Like:

 #define MAX_FILENAME (PKTLINE_DATA_MAXLEN - strlen("filename"))

 if (filename > MAX_FILENAME) {
	warning("woah, that name is ridiculous; truncating");
	ret = packet_write_fmt_gently(fd, "%.*s", MAX_FILENAME, filename);
 } else
	ret = packet_write_fmt_gently(fd, "%s", filename);

I can do that. However, I wouldn't truncate the filename as this
might create a weird outcome. I would just let the filter fail.

Yeah, I think that is probably fine (I don't have a real opinion for
this particular case, but was mostly just trying to think about whether
the pktline interface was suitably flexible).

-Peff