Re: [PATCH v9 39/41] apply: change error_routine when silent

On Mon, Aug 1, 2016 at 6:58 PM, Stefan Beller [off-list ref] wrote:

On Sat, Jul 30, 2016 at 10:25 AM, Christian Couder
[off-list ref] wrote:

quoted

+       /* This is to save some reporting routines */

some?

In case of a reroll could you be more specific?
Specifically mention that we use these for the
muting/when silence is requested.
e.g.
/* These control reporting routines, and are used e.g. for muting output */

quoted

+       void (*saved_error_routine)(const char *err, va_list params);
+       void (*saved_warn_routine)(const char *warn, va_list params);

I used the following instead of your suggestion:

    /*
     * This is to save reporting routines before using
     * set_error_routine() or set_warn_routine() to install muting
     * routines when in verbosity_silent mode.
     */

Thanks.