Re: [PATCH v2 1/2] format-patch: Add a config option format.from to set the default for --from

From
Josh Triplett <josh@joshtriplett.org>
Date
2016-08-08 04:42:26
Reply to
Junio C Hamano, 2016-08-01
On Mon, Aug 01, 2016 at 02:18:47PM -0700, Junio C Hamano wrote:
Josh Triplett [off-list ref] writes:
quoted
+enum from {
+	FROM_AUTHOR,
+	FROM_USER,
+	FROM_VALUE,
Drop trailing comma after the last enum definition (trailing comma
after the last element in an array is OK, though).
I realize this code didn't get included in the final version, but for
future reference, what's the rationale for this?  I tend to include a
final comma in cases like these (and likewise for initializers) to avoid
needing to change the last line when introducing a new element, reducing
noise in diffs.  I hadn't seen anything in any of the coding style
documentation talking about trailing commas (either pro or con).
Thread (5 messages) 5 messages, 3 authors, last reply 2016-08-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help