Re: [PATCH v3] t7063: work around FreeBSD's lazy mtime update feature
From: Duy Nguyen <hidden>
Date: 2016-08-04 15:46:49
Possibly related (same subject, not in this thread)
- 2016-08-03 · Re: [PATCH v3] t7063: work around FreeBSD's lazy mtime update feature · Junio C Hamano <hidden>
- 2016-08-03 · [PATCH v3] t7063: work around FreeBSD's lazy mtime update feature · Nguyễn Thái Ngọc Duy <hidden>
On Wed, Aug 3, 2016 at 9:07 PM, Junio C Hamano [off-list ref] wrote:
Junio C Hamano [off-list ref] writes:quoted
If you mean to tell the user "I won't describe it in detail, if you really want to know, go run blame yourself", spell it out like so. I was hoping that you can summarize in-line there to help the readers here.Here is a proposed fixup.
Great! Sorry I only have one or two hours these days and could not propose something else quicker.
quoted hunk ↗ jump to hunk
t/t7063-status-untracked-cache.sh | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)diff --git a/t/t7063-status-untracked-cache.sh b/t/t7063-status-untracked-cache.sh index d31d080..e0a8228 100755 --- a/t/t7063-status-untracked-cache.sh +++ b/t/t7063-status-untracked-cache.sh@@ -4,12 +4,16 @@ test_description='test untracked cache' . ./test-lib.sh -# On some filesystems (e.g. FreeBSD's ext2 and ufs) this and that -# happens when we do blah, which forces the untracked cache code to -# take the slow path. A test that wants to make sure the fast path -# works correctly should call this helper to make mtime of the -# containing directory in sync with the reality after doing blah and -# before checking the fast path behaviour +# On some filesystems (e.g. FreeBSD's ext2 and ufs) directory mtime +# is updated lazily after contents in the directory changes, which +# forces the untracked cache code to take the slow path. A test +# that wants to make sure that the fast path works correctly should +# call this helper to make mtime of the containing directory in sync +# with the reality before checking the fast path behaviour. +# +# See <20160803174522.5571-1-pclouds@gmail.com> if you want to know +# more. + sync_mtime () { find . -type d -ls >/dev/null }
-- Duy