Thread (5 messages) flat view 5 messages, 4 authors, 2016-08-05

Re: [RFC/PATCH] rebase--interactive: Add "sign" command

From: Jeff King <hidden>
Date: 2016-08-03 18:15:18

On Wed, Aug 03, 2016 at 09:08:48AM -0700, Junio C Hamano wrote:
quoted
However, I could imagine that we actually want this to be more extensible.
After all, all you are doing is to introduce a new rebase -i command that
does nothing else than shelling out to a command.
Yup, I tend to agree.

Adding "sign" feature (i.e. make it pass -S to "commit [--amend]")
may be a good thing, but adding "sign" command to do so is not a
great design.
I'm not sure what you mean by "feature" here, but it reminded me of
Michael's proposal to allow options to todo lines:

  http://public-inbox.org/git/530DA00E.4090402@alum.mit.edu/

which would allow:

  pick -S 1234abcd

If that's what you meant, I think it is a good idea. :)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help