Thread (1 message) 1 message, 1 author, 2016-08-03

Re: [PATCH v4 0/8] status: V2 porcelain status

From: Junio C Hamano <hidden>
Date: 2016-08-03 17:05:35

Johannes Schindelin [off-list ref] writes:
On Wed, 3 Aug 2016, Junio C Hamano wrote:
quoted
On Wed, Aug 3, 2016 at 8:09 AM, Johannes Schindelin
[off-list ref] wrote:
quoted
Any word when it will be included in `pu`, at least?
I've been waiting to see that the amount and quality of
comments from others indicate that the series passed
the phase that goes through frequent rerolls. Having a
serious review in the thread that demonstrates and
concludes that it is well designed, well implemented,
and ready to go would help, of course.
Oh, I thought I had stated clearly already that what with Jeff being my
colleague and working on a feature I have a lot of interest in, I had
reviewed this patch series even before it was submitted to the Git mailing
list.

What I meant by a "serious review" is a bit more than "I reviewed
without involving the list, and you know me well enough, trust me".

Even if a reviewer does not see any more need to change the patch,
perhaps because it is perfect after internal reviews, a reviewer can
still point out positive things, e.g. what is done well compared to
other possible approaches and in what way the presented patch is
better than possible alternatives.  See my response to your import-tars
update for an example.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help