Thread (3 messages) flat view 3 messages, 2 authors, 2016-08-01

Re: [PATCH] reset cached ident date before creating objects

From: Junio C Hamano <hidden>
Date: 2016-08-01 17:49:34

Possibly related (same subject, not in this thread)

Jeff King [off-list ref] writes:
quoted
So maybe we would have to put reset_ident_date() at the end of the
function instead, at least after git_committer_info() is called.
Yes, although "reset and end" still feels a bit weird to me.

I'd almost prefer to just have long-running programs insert resets at
strategic points.
Certainly "reset at the end" feels weird but it can be explained as
"for a one-shot thing we use the first time of the default date and
it gives a consistent timestamp; conceptually, things that make
multiple commits are like doing that one-shot thing multiple times
in a row."

When viewed that way, it is not _too_ bad, I would guess.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help