Re: [PATCH] t5510: skip tests under GETTEXT_POISON build
From: Junio C Hamano <hidden>
Date: 2016-07-26 16:55:21
Vasco Almeida [off-list ref] writes:
quoted hunk
Skip tests when running under GETTEXT_POISON build and run them with C_LOCALE_OUTPUT prerequisite. These tests are irrelevant under GETTEXT_POISON because they test text output alignment which GETTEXT_POISON turns useless. Signed-off-by: Vasco Almeida <redacted> --- t/t5510-fetch.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh index 6bd4853..668c54b 100755 --- a/t/t5510-fetch.sh +++ b/t/t5510-fetch.sh@@ -688,7 +688,7 @@ test_expect_success 'fetching with auto-gc does not lock up' ' ) ' -test_expect_success 'fetch aligned output' ' +test_expect_success C_LOCALE_OUTPUT 'fetch aligned output' ' git clone . full-output && test_commit looooooooooooong-tag && (@@ -703,7 +703,7 @@ test_expect_success 'fetch aligned output' ' test_cmp expect actual ' -test_expect_success 'fetch compact output' ' +test_expect_success C_LOCALE_OUTPUT 'fetch compact output' ' git clone . compact && test_commit extraaa && (
Makes sense, will queue.
This is a tangent, but it may make sense for us to start thinking
about retiring one of the two prerequisites, GETTEXT_POISON and
C_LOCALE_OUTPUT. Back when 5e9637c6 (i18n: add infrastructure for
translating Git with gettext, 2011-11-18) introduced the former,
test_have_prereq did not support a negated prerequisite, so the
commit added GETTEXT_POISON prerequisite; if we had the modern
test_have_prereq, we would have written
test_expect_success GETTEXT_POISON '...'
that appear in t0205 as
test_expect_success !C_LOCALE_OUTPUT '...'
I would think.