Thread (1 message) 1 message, 1 author, 2016-07-26

Re: [PATCH 1/3] t7900-subtree.sh: fix quoting and broken && chains

From: Junio C Hamano <hidden>
Date: 2016-07-26 06:46:16

Eric Sunshine [off-list ref] writes:
quoted
@@ -73,10 +73,10 @@ join_commits()
 test_create_commit() (
        repo=$1
        commit=$2
Perhaps &&-chain the above two lines also to future-proof against
someone inserting important code somewhere above the following 'cd'.
Yup, also we can have them on a single line, i.e.

	repo=$1 commit=$2 &&
	cd "$repo" &&
        ...

Thanks
quoted
-       cd "$repo"
-       mkdir -p $(dirname "$commit") \
+       cd "$repo" &&
+       mkdir -p "$(dirname "$commit")" \
        || error "Could not create directory for commit"
-       echo "$commit" >"$commit"
+       echo "$commit" >"$commit" &&
        git add "$commit" || error "Could not add commit"
        git commit -m "$commit" || error "Could not commit"
 )
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help