Re: [PATCH v4 02/16] Report bugs consistently
From: Junio C Hamano <hidden>
Date: 2016-07-25 21:44:47
Johannes Schindelin [off-list ref] writes:
quoted hunk
diff --git a/imap-send.c b/imap-send.c index db0fafe..67d67f8 100644 --- a/imap-send.c +++ b/imap-send.c@@ -506,12 +506,12 @@ static char *next_arg(char **s) static int nfsnprintf(char *buf, int blen, const char *fmt, ...) { - int ret; + int ret = -1; va_list va; va_start(va, fmt); if (blen <= 0 || (unsigned)(ret = vsnprintf(buf, blen, fmt, va)) >= (unsigned)blen) - die("Fatal: buffer too small. Please report a bug."); + die("BUG: buffer too small (%d < %d)", ret, blen); va_end(va); return ret; }
If "you gave me this size but you need at least this much" is truly worth reporting, then this is misleading (ret is shown as -1 but you do not even know how much is necessary). In any case, this should be done as a separate step anyway. All the other hunks looked sensible. Thanks.