Re: [PATCH] submodule: do no re-read name in shell script
From: Jonathan Nieder <hidden>
Date: 2016-07-21 01:01:03
Stefan Beller wrote:
quoted hunk ↗ jump to hunk
Instead of making another call to a submodule helper (name), just propagate the value when we know it (in the update-clone helper) already. Signed-off-by: Stefan Beller <redacted> --- builtin/submodule--helper.c | 4 ++-- git-submodule.sh | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-)diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index b22352b..494e088 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c@@ -683,9 +683,9 @@ static int prepare_to_clone_next_submodule(const struct cache_entry *ce, needs_cloning = !file_exists(sb.buf); strbuf_reset(&sb); - strbuf_addf(&sb, "%06o %s %d %d\t%s\n", ce->ce_mode, + strbuf_addf(&sb, "%06o %s %d %d %s\t%s\n", ce->ce_mode, sha1_to_hex(ce->sha1), ce_stage(ce), - needs_cloning, ce->name); + needs_cloning, sub->name, sub->path);
Are there any restrictions on what characters a submodule name can contain? Does this need e.g. to be quoted with sq_quote? Thanks, Jonathan