Re: [PATCH 3/3] difftool: use Git::* functions instead of passing around state
From: Junio C Hamano <hidden>
Date: 2016-07-19 18:29:10
David Aguilar [off-list ref] writes:
Call Git::command() and friends directly wherever possible. This makes it clear that these operations can be invoked directly without needing to manage the current directory and related GIT_* environment variables.
Good.
quoted hunk
@@ -88,11 +80,11 @@ sub changed_files my @refreshargs = ( @gitargs, 'update-index', '--really-refresh', '-q', '--unmerged'); - my @diffargs = (@gitargs, 'diff-files', '--name-only', '-z'); try { Git::command_oneline(@refreshargs); } catch Git::Error::Command with {}; + my @diffargs = (@gitargs, 'diff-files', '--name-only', '-z'); my $line = Git::command_oneline(@diffargs); my @files; if (defined $line) {
This hunk looks like "oops, the @diffargs variable logically belongs here, not there", correcting an mistake in an earlier step.