Thread (3 messages) flat view 3 messages, 3 authors, 2016-07-19

Re: [PATCH] contrib/persistent-https: update ldflags syntax for Go 1.7+

From: Shawn Pearce <hidden>
Date: 2016-07-19 04:49:40

On Mon, Jul 18, 2016 at 9:32 PM, Parker Moore [off-list ref] wrote:
quoted
The label does not even identify the version of the source in any way, so I am not sure how people are depending on that feature anyway ;-)
Would it be a better solution simply to remove this build flag?
Alternatively, if Git wished to support Go v1.5 and below, I would be
more than happy to send a patch with a dynamic lookup in the Makefile
based on the output of `go version`. I would be more than happy to
submit either patch.
I think we could remove that BUILD_LABEL entirely. Colby liked having
a marker so he knows what "version" a user is running, but without any
correlation to source here it just isn't that useful.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help