Thread (1 message) 1 message, 1 author, 2016-07-18

Re: [PATCH] test-lib: stricter unzip(1) check

From: Junio C Hamano <hidden>
Date: 2016-07-18 19:17:57

Jeff King [off-list ref] writes:
On Mon, Jul 18, 2016 at 11:20:19AM -0700, Junio C Hamano wrote:
quoted
Stepping back a bit, why do we even care if "unzip -a" works on
"../$zipfile" and converts things correctly in that check_zip() test
in t5003 in the first place?  It looks more like a test on "unzip"
than making sure we correctly generate a zip archive to me...
I think it is testing that we generated an archive with the correct "I
am text" flags so that an unzip implementation can do the
auto-conversion.
Yes, I understand that.  I was hoping for a response along the lines
of "we want to make sure we mark text as text, and 'zip -l' has an
option to let us check the attributes without having to actually
checking things out" ;-)

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help