Re: [PATCH] git-svn: clone: Fail on missing url argument

Eric Wong [off-list ref] writes:

Christopher Layne [off-list ref] wrote:

quoted

* cmd_clone should detect a missing $url arg before using it otherwise
  an uninitialized value error is emitted in even the simplest case of
  'git svn clone' without arguments.

Thanks, this patch looks obviously correct.

I've eliminated the '* ' and space prefix from the version I've
applied since it's not the convention around here.

quoted

Signed-off-by: Christopher Layne <redacted>

Signed-off-by: Eric Wong <redacted>

And pushed to "master" of git://bogomips.org/git-svn
(I'll request for Junio to pull within a few days while
 other changes pile up).

Thanks.

quoted

 sub cmd_clone {
 	my ($url, $path) = @_;
-	if (!defined $path &&
+	if (!$url) {
+		die "SVN repository location required ",
+		    "as a command-line argument\n";

"as a command-line argument" seems like an unnecessary phrase,
but I see we use it elsewhere; so it's fine here.

I might be tempted to queue up a separate patch
to eliminate this extra statement from the rest of git-svn,
though.  Not sure if others feel the same way.

If it _can_ come from somewhere else (perhaps a future enhancement
may allow you to configure where to clone from?  Not likely for
cmd_clone but other places in git-svn may be talking about something
that could be configured in the future), then "as a command-line
argument" is not just unnecessary but actively waiting to harm the
users.

But otherwise I do not think anybody cares either way.