Thread (13 messages) flat view 13 messages, 5 authors, 2016-07-09

Re: [PATCH] revert: clarify seemingly bogus OPT_END repetition

From: Johannes Schindelin <hidden>
Date: 2016-07-06 07:32:33

Hi Peff,

On Tue, 5 Jul 2016, Jeff King wrote:
+	ALLOC_ARRAY(ret, st_add3(a_len, b_len, 1));
+	for (i = 0; i < a_len; i++)
+		ret[i] = a[i];
+	for (i = 0; i < b_len; i++)
+		ret[a_len + i] = b[i];
+	ret[a_len + b_len] = b[b_len]; /* final OPTION_END */
Not really a big deal, but I'd have written "i <= b_len" in the for loop
and avoided the final line. However, your version is clearer.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help