Re: git svn clone segmentation faul issue

Hi Johanes,

Johannes Schindelin <Johannes.Schindelin <at> gmx.de> writes:

Hi Ioannis,

On Tue, 28 Jun 2016, Johannes Schindelin wrote:

quoted

On Tue, 28 Jun 2016, Ioannis.Kappas <at> rbs.com wrote:

quoted

Git can fail with a "malformed index nnn" error or cause a 

segmentation

quoted

quoted

fault when executing the "git svn clone" command. 

[...]

Fortunately, a patch has already been submitted to subversion with
(github) revision a074af86c8764404b28ce99d0bedcb668a321408 (at
https://github.com/apache/subversion/commit/a074af86c8) on the trunk 

to

quoted

quoted

handle this and a couple of other similar cases. But by the looks of 

it

quoted

quoted

has not been picked up yet in the latest subversion 1.9.4 release or 

the

quoted

quoted

1.9.x branch, perhaps because this patch was identified in sanity 

checks

quoted

quoted

rather than coming out from a perceivable production issue?

This is an excellent analysis and a silver lining on the horizon to
resolve those vexing git svn issues we keep having in Git for Windows.

Do you have a test case that is reliably reproducing the issue?

I hope you do! 

Yes, my codebase always fails on git svn clone with something like:

fatal: malformed index info 100644 a6d6543f625fb4a7200e
error: git-svn died of signal 11

I patched the MSYS2 build script to apply a074af86c8 before
compiling, and uploaded the resulting packages for i686 and x86_64
architectures to

	https://github.com/dscho/MSYS2-

packages/releases/tag/subversion-1.9.4-2

Would you mind giving them a whirl?

The patch in "source code (zip)" seems to be missing the line in the prepare
() section of PKGBUILD to actually apply the fix:

diff --git a/subversion/PKGBUILD b/subversion/PKGBUILD
--- a/subversion/PKGBUILD
+++ b/subversion/PKGBUILD

@@ -101,6 +103,7 @@ prepare() {
   patch -p1 -i ${srcdir}/17-fix-test-link.patch
   patch -p1 -i ${srcdir}/18-fix-serf-config.patch
   patch -p1 -i ${srcdir}/19-remove-contrib-from-configure.patch
+  patch -p1 -i ${srcdir}/20-fix-stack-corruption-in-swig-wrappers.patch
   patch -p1 -i ${srcdir}/subversion-1.9.1-msys2.patch
   patch -p1 -i ${srcdir}/remove-checking-symlink.patch
   patch -p1 -i ${srcdir}/90-use-copy-instead-symlink.patch

Would you be so kind to add the above and rebuild. 

I have just tested it locally to work successfully, but I do not mind 
retesting if you wish to provide another build :)

Thanks,
Yannis

Thanks,
Johannes