Thread (71 messages) flat view 71 messages, 4 authors, 2016-07-06

Re: [PATCH v2 0/6] convert various shell functions in git-bisect to C

From: Pranit Bauva <hidden>
Date: 2016-06-16 06:55:53

Hey Eric,

On Wed, Jun 15, 2016 at 11:23 PM, Eric Sunshine [off-list ref] wrote:
On Wed, Jun 15, 2016 at 10:00 AM, Pranit Bauva [off-list ref] wrote:
quoted
Changes wrt previous version:
 * Use STRING_LIST_INIT_NODUP to avoid leaks in bisect_clean_state()
 * Use test_path_is_missing in the patch 2/6
 * drop file_size()
 * move is_empty_file() method from builtin/am.c to wrapper.c
 * use static for methods
 * remove the variable status in bisect_reset() altogether and put the whole
   thing inside the if block.
 * one more method converted namely bisect_write().
As an aid to reviewers, in the future, please also include in the
cover letter an interdiff between the previous and current version of
the patch series. Thanks.
Sure!

Regards,
Pranit Bauva
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help