Re: [PATCH v6 31/44] run-command: make dup_devnull() non static
From: Johannes Sixt <hidden>
Date: 2016-06-16 02:19:52
Am 10.06.2016 um 22:11 schrieb Christian Couder:
quoted hunk ↗ jump to hunk
--- a/run-command.c +++ b/run-command.c@@ -85,7 +85,7 @@ static inline void close_pair(int fd[2]) } #ifndef GIT_WINDOWS_NATIVE -static inline void dup_devnull(int to) +void dup_devnull(int to)
I'm not adding arguments to what we've heard on whether to use /dev/null in this series or not. But if the outcome is to keep this patch, please remove the #ifndef that we see in the context lines (and the matching #endif), too. Otherwise, the build fails on Windows for each patch in the series until this change is reverted in patch 42/44. -- Hannes