Re: [RFC/PATCH] verify-tag: add --check-name flag
flat view
From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:49
Santiago Torres [off-list ref] writes:
Sorry I'm trying to follow this. Would it be best to then have
verify-tag [--check-name=tagname] (tag-ref|tag-name|sha1)?
and
tag -v [--check-name] (tag-name)
Or would --format still work better?
No matter what you do, don't call that "--check-name". It does not
tell the users what aspect of that thing is "checked". Avoid being
asked "Does this check tagname to make sure it does not have
non-ASCII letters?", in other words.
As a longer-term direction, I think the best one is to make what
peff@ originally suggested, i.e.
If we do go with the "print it out and let the caller do their own
checks" strategy, I think I'd prefer rather than "--show-tagname" to
just respect the "--format" we use for tag-listing. That would let you
do:
git tag -v --format='%(tag)%n%(tagger)'
or similar. In fact you can already do that with a separate step (modulo
%n, which we do not seem to understand here)...
work.
Thanks.