Re: [PATCH 1/2] git-prompt.sh: Don't error on null ${ZSH,BASH}_VERSION, $short_sha

On Mon, Jun 6, 2016 at 11:08 PM, Junio C Hamano [off-list ref] wrote:

Ville Skyttä [off-list ref] writes:

quoted

When the shell is in "nounset" or "set -u" mode, referencing unset or
null variables results in an error. Protect $ZSH_VERSION and
$BASH_VERSION against that, and initialize $short_sha before use.

Signed-off-by: Ville Skyttä <redacted>
---

Thanks for following up.  I do not run my interactive shells with
"set -u", so I never noticed these, but apparently you do (or you
know who does)

I don't personally, but some do. The issue pops up every now and then
with bash-completion, e.g.
https://github.com/scop/bash-completion/issues/44

does this patch cover everything that is not "-u" safe?

I don't know. These were the low hanging fruits I've come across. Null
$ZSH_VERSION in git-prompt.sh was the thing I ran into immediately
when enabling "nounset" mode to start looking into the above
bash-completion issue. Quick testing with zsh revealed the same issue
with null $BASH_VERSION, and you found the $short_sha one.