Re: Segfault in the attr stack

From
Duy Nguyen <hidden>
Date
2016-06-16 02:19:42
Reply to
Junio C Hamano, 2016-06-16
On Thu, Jun 2, 2016 at 5:17 AM, Junio C Hamano [off-list ref] wrote:
Gaah, of course.

This is coming from the cache preload codepath, where multiple threads
try to run ce_path_match().
It used to be OK because pathspec magic never looked at attributes,
but now it does, and attribute system is not thread-safe.
Off topic. I wonder if we can annotate which functions are thread-safe
(minority currently in git code base, I believe) and make gcc, clang
or sparse spot them in threaded code?
-- 
Duy
Thread (5 messages) 5 messages, 3 authors, last reply 2016-06-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help