Re: [PATCH] clone: don't use an integer as a NULL pointer
From: Stefan Beller <hidden>
Date: 2016-06-16 02:19:36
On Wed, May 25, 2016 at 4:12 PM, Ramsay Jones [off-list ref] wrote:
Signed-off-by: Ramsay Jones <redacted> --- Hi Stefan, If you need to re-roll your 'sb/submodule-default-paths' branch, could you please squash this into the relevant patch. (commit 8efbe28b, "clone: add --init-submodule=<pathspec> switch", 23-05-2016). Thanks! ATB, Ramsay Jones
Thanks for pointing out! I am sorry for having you write me these emails; Out of curiosity, how much of this is manual work and how much did you automate of this?
quoted hunk ↗ jump to hunk
builtin/clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/builtin/clone.c b/builtin/clone.c index 22b6eac..a056f72 100644 --- a/builtin/clone.c +++ b/builtin/clone.c@@ -925,7 +925,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix) struct strbuf sb = STRBUF_INIT; for_each_string_list_item(item, &init_submodules) { strbuf_addf(&sb, "submodule.defaultUpdatePath=%s", item->string); - string_list_append(&option_config, strbuf_detach(&sb, 0)); + string_list_append(&option_config, strbuf_detach(&sb, NULL)); } } --2.8.0