Thread (4 messages) 4 messages, 2 authors, 2016-06-16

Re: [PATCH v7 1/2] http.c: implement the GIT_TRACE_CURL environment variable

flat view

From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:36

On Mon, May 23, 2016 at 6:44 AM, Elia Pinto [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+static void curl_dump_header(const char *text, unsigned char *ptr, size_t size, int hide_sensitive_header)
+{
+       struct strbuf out = STRBUF_INIT;
+       const char *sensitive_header;
This variable now has become unused, so I'll remove it while queuing.

Thanks.
quoted hunk ↗ jump to hunk
+       struct strbuf **headers, **header;
+
+       strbuf_addf(&out, "%s, %10.10ld bytes (0x%8.8lx)\n",
+               text, (long)size, (long)size);
+       trace_strbuf(&trace_curl, &out);
+       strbuf_reset(&out);
+       strbuf_add(&out, ptr, size);
+       headers = strbuf_split_max(&out, '\n', 0);
+
+       for (header = headers; *header; header++) {
+               if (hide_sensitive_header)
+                       redact_sensitive_header(*header);
+               strbuf_insert((*header), 0, text, strlen(text));
+               strbuf_insert((*header), strlen(text), ": ", 2);
+               strbuf_rtrim((*header));
+               strbuf_addch((*header), '\n');
+               trace_strbuf(&trace_curl, (*header));
+       }
+       strbuf_list_free(headers);
+       strbuf_release(&out);
+}
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help