Thread (1 message) 1 message, 1 author, 2016-06-16

Re: [PATCH v8 3/3] bisect--helper: `write_terms` shell function in C

From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:35

Christian Couder [off-list ref] writes:
quoted
diff --git a/git-bisect.sh b/git-bisect.sh
index 7d7965d..cd39bd0 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -210,7 +210,7 @@ bisect_start() {
        eval "$eval true" &&
        if test $must_write_terms -eq 1
        then
-               write_terms "$TERM_BAD" "$TERM_GOOD"
+               git bisect--helper --write-terms "$TERM_BAD" "$TERM_GOOD" || exit
This `|| exit` is not needed because...
quoted
        fi &&
        echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit
... there is an `|| exit` on the line above (which is chained using
`&&` to the previous lines).
Could you please trim parts that you are not commenting on when
quoting?  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help